Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product editor fixes #240

Merged
merged 29 commits into from
Mar 13, 2020
Merged

Product editor fixes #240

merged 29 commits into from
Mar 13, 2020

Conversation

mikemurray
Copy link
Member

@mikemurray mikemurray commented Mar 6, 2020

Resolves #237
Impact: minor
Type: feature|bugfix

Issue

There are various issues with the product editor outlined in this ticket #237

Solution

Fixed

  • Variants in the sidebar are highlighted when active
  • Inconsistent notification. Now all toasts use notistack
  • Archived variants and options seem to work. Not sure if I fixed it, or if some other issue was at play
  • Refactor GQL queries/mutations to use fragments and moved out of hook file
  • In the useProduct hook, skip queries that require shopId if the shopId is not available

Not fixed

Breaking changes

none

Testing

  1. Ensure variants and options are highlighted
  2. Check the code for the queries/mutations
  3. Ensure variants and options can be archived

Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
Signed-off-by: Mike Murray <[email protected]>
@mikemurray mikemurray changed the title [WIP] Product editor fixes Product editor fixes Mar 12, 2020
@mikemurray mikemurray marked this pull request as ready for review March 12, 2020 16:36
@willopez
Copy link
Member

Related API issue here: reactioncommerce/reaction#6148

Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
An issue in the API repo has been created to track a new issue related to duplicating products

@willopez willopez merged commit d736860 into trunk Mar 13, 2020
@kieckhafer kieckhafer mentioned this pull request Apr 2, 2020
@Akarshit Akarshit deleted the fix-237-mikemurray-product-editor branch February 4, 2021 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New product editor issues
2 participants